[BUGFIX] Restored handling of ROCM FA output as before adaptation of llama3.2#241
Merged
maleksan85 merged 3 commits intomainfrom Oct 23, 2024
Merged
[BUGFIX] Restored handling of ROCM FA output as before adaptation of llama3.2#241maleksan85 merged 3 commits intomainfrom
maleksan85 merged 3 commits intomainfrom
Conversation
maleksan85
changed the title
maleksan85
changed the title
gshtras
previously approved these changes
Oct 22, 2024
gshtras
approved these changes
Oct 22, 2024
maleksan85
added a commit
that referenced
this pull request
Nov 19, 2024
…llama3.2 (#241) * improved handling of output to be the same as before * after merge correction --------- Co-authored-by: Aleksandr Malyshev <maleksan@amd.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Output from FA should contain all prefix items, plus whatever decode phase uses.